Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash completion with git 2.30.0 and higher #2948

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cblecker
Copy link

This implements the fix proposed by @ches here: #2684 (comment)

I've been running this in my local env for over a year without issue, but when installing hub on a new machine, it messed up my bash completions for git, so I thought I'd actually open this PR.

fixes #2684

Copy link
Owner

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Is this backwards-compatible with git 2.29 and lower?

@cblecker
Copy link
Author

I've done basic testing on 2.29.2 and it works, but haven't done a complete regression test or anything.

@cblecker
Copy link
Author

(P.S. If it's possible for a version to be cut with this and #2939, it would be much appreciated)

@cblecker
Copy link
Author

@mislav: friendly nudge :) is getting this merged and a release cut possible? Thank you!

Co-authored-by: Ches Martin <ches@whiskeyandgrits.net>
@kbrock
Copy link
Contributor

kbrock commented Jul 28, 2023

Thanks for putting this PR together

I verified it works on my system. (red green tested)
When installing but git is not installed, autocomplete didn't work so well. But I'm assuming that git needs to be installed in that case

I put other notes in the main issue

==> bash-completion@2: stable 2.11 (bottled), HEAD
==> git: stable 2.41.0 (bottled), HEAD
==> hub: stable 2.14.2 (bottled), HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bash completion incompatibility with git 2.30.0
3 participants