Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound ducking release not smooth #43

Closed
qcapen opened this issue May 4, 2016 · 2 comments
Closed

Sound ducking release not smooth #43

qcapen opened this issue May 4, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@qcapen
Copy link
Collaborator

qcapen commented May 4, 2016

The release portion of the sound ducking envelope does not transition smoothly back to full volume over the specified duration. Instead the release begins smoothly and then suddenly jumps back to full volume.

@qcapen qcapen self-assigned this May 4, 2016
@qcapen qcapen added this to the 0.30 milestone May 4, 2016
@qcapen
Copy link
Collaborator Author

qcapen commented May 27, 2016

This bug is caused by comparisons in the code between signed and unsigned integers causing undesired behavior and calculations. To resolve, I am going through all signed/unsigned integer variables and ensuring their consistent use and proper casting when comparisons are necessary. Sample positions/durations are unsigned values while envelope stage positions can be negative therefore are signed. The code did not properly cast variables of mixed types when performing comparison operations.

qcapen added a commit that referenced this issue May 27, 2016
Fixes issue #43. Fixed signed/unsigned int comparisons to either
explicitly cast values or changed underlying variable types.  Integer
variable types are now more consistent throughout the module.
@qcapen
Copy link
Collaborator Author

qcapen commented May 27, 2016

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants