FAST Neuron should ignore switches on other platforms #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosh
commented
Sep 30, 2024
| @@ -294,6 +294,9 @@ def update_switches_from_hw_data(self): | |||
| it will process it like any switch change. | |||
| """ | |||
| for switch in self.machine.switches.values(): | |||
| if switch.platform != self.platform: | |||
There was a problem hiding this comment.
I expect there's a better way in python to filter, and then not even need the continue
There was a problem hiding this comment.
You should be able to do it like this:
for switch in self.machine.switches.values() if switch.platform == self.platform:
There was a problem hiding this comment.
Took a few whacks at it and found the final syntax. It's a little awkward imo, but it's in :)
bosh
force-pushed
the
fast_switch_filter_pr
branch
from
d5d01c8
to
740d66f
Compare
bosh
force-pushed
the
fast_switch_filter_pr
branch
from
740d66f
to
059786a
Compare
|
|
PR is all ready for final review! I've also tested the current version (with the list comprehension) on my neuron, no problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using multiple platforms for switches, the Neuron communicator will try to look up every switch as though they are connected to FAST hardware, causing a crash. This is a bad assumption and it keeps a machine creator from declaring virtual switches when using a Neuron.
Virtual switches can be useful in letting a machine developer add switches to configs before they're wired into the machine, or even by creating virtual-only switches that will never be physically implemented, but can be used in mpf-monitor for debugging and arbitrary event creation.
First commit changes Neuron platform tests to be explicit about which platform they're using (instead of defaulting) but should be green. (Action run: https://github.com/bosh/mpf/actions/runs/10966582957 )
Second commit changes the test to include a cross-platform switch that causes crashes (9x crash in that test file due to Neuron not filtering switch platform) (Action run: https://github.com/bosh/mpf/actions/runs/10966584585 )
Third commit fixes the Neuron communicator code. I'm not sure of the best syntax for this in Python (could we filter the .values() call?) but it works :)