Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/replace webpack tasks on babel #108

Merged

Conversation

@n-filatov
Copy link
Contributor

@n-filatov n-filatov commented Sep 3, 2017

Ref: #105
I saved webpack for build:example and test tasks.

@shaypeleg1
Copy link

@shaypeleg1 shaypeleg1 commented Sep 3, 2017

What's the bundle size now after build?

@n-filatov
Copy link
Contributor Author

@n-filatov n-filatov commented Sep 3, 2017

@shaypeleg1 107.25 KB

@ai
Copy link
Contributor

@ai ai commented Sep 3, 2017

@Muffassa you forget to remove webpack from dependencies and remove unnecessary build scripts.

Also can you post here npx size-limit --why result? To be sure that PropTypes was removed.

@n-filatov
Copy link
Contributor Author

@n-filatov n-filatov commented Sep 3, 2017

@ai Removed unnecessary build scripts. I tried remove webpack, but it required for building example build and running test.

@ai
Copy link
Contributor

@ai ai commented Sep 3, 2017

@Muffassa at least you can remove webpack-bundle-analyzer since size-limit --why does the same

@n-filatov
Copy link
Contributor Author

@n-filatov n-filatov commented Sep 3, 2017

@ai done

@EtienneLem EtienneLem merged commit bbe152f into missive:master Sep 4, 2017
@EtienneLem
Copy link
Member

@EtienneLem EtienneLem commented Sep 4, 2017

Awesome, thanks @Muffassa for contributing 🤘

@sonicdoe
Copy link
Contributor

@sonicdoe sonicdoe commented Sep 5, 2017

I’m not sure I fully understand the reasoning behind removing propTypes in the build. As far as I can tell, I’ll now no longer benefit from propTypes during development. Shouldn’t babel-plugin-transform-react-remove-prop-types only be used by the application developer when doing a production build?

@ai
Copy link
Contributor

@ai ai commented Sep 5, 2017

@sonicdoe theoretically, yes. But in practice, many developers don’t know about this babel-plugin-transform-react-remove-prop-types. We can add it to docs, but users don’t read docs.

But if type checking is really important, we can move this babel plugin to docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants