Executable names might be truncated (darwin, linux) #15
Comments
|
Looks great! Can you point me to where I should merge any changes? |
|
You could create a pull request (or compare changes) and then pick and choose what changes you want? master...keybase:master If you need, I could also prepare a pull-request which has these fixes (and adds more tests etc), but might be a week or so before I can get to it. |
|
Still confirming this as a problem. Do you need a hand? Ran into a bug downstream with goss because of this. |
|
Thanks for pointing me to the fork, @gabriel . |
|
I can confirm it does truncate the names in linux. |
|
Fix for now is to just import github.com/keybase/go-ps |
The old mitchellh go-ps is not maintained and it has an issue where it truncates the process names: mitchellh/go-ps#15 - Related: #152
|
do we have fix available for linux ? Are we going to merge it as I still see the same problem in github.com/mitchellh/go-ps ? |
Currently, on macOS Standonlone version if local client returns any errors while tailscaled is running, cli would not print the error at all, showing only that Tailscale might not be running. Add tailscaled process name of macsys version, so that fixTailscaledConnectError reports error correctly. Contains workaround for go-ps bug which trims long process names (>16 characters): mitchellh/go-ps#15
Currently, on macOS Standalone version if local client returns any errors while tailscaled is running, cli would not print the error at all, showing only that Tailscale might not be running. Add tailscaled process name of macsys version, so that fixTailscaledConnectError reports error correctly. Contains workaround for go-ps bug which trims long process names (>16 characters): mitchellh/go-ps#15
Currently, on macOS Standalone version if local client returns any errors while tailscaled is running, cli would not print the error at all, showing only that Tailscale might not be running. Add tailscaled process name of macsys version, so that fixTailscaledConnectError reports error correctly. Contains workaround for go-ps bug which trims long process names (>16 characters): mitchellh/go-ps#15 Signed-off-by: Ilya Lukyanov <il@joom.com>
The old mitchellh go-ps is not maintained and it has an issue where it truncates the process names: mitchellh/go-ps#15 - Related: #152
Process names might be truncated on darwin, linux.
This fork here which has the full process executable path, uses filepath.Base(..) to get the full name:
https://github.com/keybase/go-ps
The text was updated successfully, but these errors were encountered: