This repository was archived by the owner on Jan 28, 2020. It is now read-only.
Wrapped course imports in transaction #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisecapella
force-pushed
the
fix/gs/transaction
branch
from
27f0dd9 to
0c2e342
Compare
There was a problem hiding this comment.
this can be a lot of stuff in a single transaction... what's the impact on the memory for the DB?
There was a problem hiding this comment.
I don't believe there would be any extra memory usage, I think transactions do their business in a separate blocks in the database and then switch over once the transaction is complete. I talked to @bdero and he was thinking that since we're using Postgres the bad experiences with transactions with edx may not apply.
|
I've confirmed that the course is created within |
noisecapella
pushed a commit
that referenced
this pull request
Oct 19, 2015
Wrapped course imports in transaction
This was referenced Nov 2, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #756