Increase socket-timeout #2010
Merged
Increase socket-timeout #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.59% (diff: 100%)@@ master #2010 diff @@
==========================================
Files 287 287
Lines 20322 20461 +139
Methods 2477 2530 +53
Messages 0 0
Branches 1801 1808 +7
==========================================
+ Hits 18602 18741 +139
Misses 1687 1687
Partials 33 33
|
rhysyngsun
reviewed
Dec 7, 2016
uwsgi.ini
Outdated
| socket-timeout = %(_) | ||
| endif = | ||
| if-not-env = UWSGI_SOCKET_TIMEOUT | ||
| socket-timeout=30 |
There was a problem hiding this comment.
My only nit here is the inconsistent spacing between this and the if-env. Otherwise 👍
Updated uWSGI config to allow for setting the timeout via an env var
The default socket-timeout is now 30s when there is no value set for UWSGI_SOCKET_TIMEOUT
blarghmatey
force-pushed
the
gs/increase_socket_timeout
branch
from
9ff2cd2 to
b51749b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
fixes #1971
What's this PR do?
Increases
socket-timeoutuwsgi setting to help prevent timeoutHow should this be manually tested?
In Chrome turn on GPRS throttling and upload a 2mb profile image. It should take a while but it should complete without error.