Added medium sized image to profile model and REST API #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisecapella
force-pushed
the
gs/image_medium
branch
from
2595896 to
a50f4f9
Compare
Current coverage is 85.59% (diff: 100%)@@ master #2218 diff @@
==========================================
Files 218 218
Lines 11471 11478 +7
Methods 975 975
Messages 0 0
Branches 1565 1565
==========================================
+ Hits 9818 9825 +7
+ Misses 1624 1620 -4
- Partials 29 33 +4
|
|
the code looks good and works as expected. Just a question: what happens if the image is smaller that 128px? If this is not a problem, feel free to merge. 👍 |
|
If both dimensions of an image are smaller than 128, the image size will not change. The image will not be resized bigger than it is I'm going to wait for @roberthouse54's opinion on if 128 is a good value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes #2213
What's this PR do?
Makes
image_mediumfor theProfilemodel and the/api/v0/profiles/.../REST API.How should this be manually tested?
Run the migrations then verify that you see a new
image_mediumURL in/api/v0/profiles/<username_here>/and that it is 128x128 pixels.Any background context you want to provide?
@roberthouse54 What pixel dimensions should this image have?