Skip to content

Conversation

shanbady
Copy link
Contributor

@shanbady shanbady commented Sep 5, 2025

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/8387

Description (What does it do?)

This PR fixes a flaky test which fails when learning resources have the same platform and readable id which violates a db constraint

How can this be tested?

  1. checkout main
  2. in the web container install pytest-repeat pip install pytest-repeat
  3. run the flaky test enough times to see it fail pytest learning_resources/tasks_test.py::test_remove_duplicate_resources --count 100 -x
  4. checkout this branch
  5. re-run the test and see it pass 100% of the time

@shanbady shanbady marked this pull request as ready for review September 5, 2025 15:27
@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Sep 5, 2025
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbertrand mbertrand self-assigned this Sep 5, 2025
@mbertrand mbertrand added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Sep 5, 2025
@shanbady shanbady merged commit 1a8a975 into main Sep 5, 2025
13 checks passed
@shanbady shanbady deleted the shanbady/flaky-test-remove_duplicate_resources branch September 5, 2025 20:37
@odlbot odlbot mentioned this pull request Sep 10, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants