Fix flaky test #2519
Merged
Fix flaky test #2519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
mbertrand
commented
Sep 17, 2025
learning_resources/tasks.py
Outdated
| learning_resources = LearningResource.objects.filter( | ||
| id__in=learning_resource_ids, etl_source=etl_source | ||
| ).values_list("id", flat=True) | ||
| ).order_by("-id").values_list("id", flat=True) |
There was a problem hiding this comment.
Since else block below is ordered by -id, I decided to do it here too for consistency.
shanbady
added
Waiting on author
and removed
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/8583
Description (What does it do?)
Fixes the intermittent test failures
How can this be tested?
pip install pytest-repeatpytest learning_resources/tasks_test.py::test_get_content_tasks --count 100 -x, test should pass every time.