Only show published runs of courses in /items/ endpoint #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbertrand
force-pushed
the
mb/fix_items_runs_view
branch
from
66842cf to
cb57fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/8778
Description (What does it do?)
Adjusts the
ResourceListItemsViewSet.querysetfilter out published runs and adds a few prefetches to get rid of some n+1 queries.How can this be tested?
python manage.py backpopulate_mitxonline_dataprogram-v1:MITx+DEDP-Public-Policy)course-v1:MITxT+14.100x)http://open.odl.local:8063/api/v1/learning_resources/<course_object_id>/, you should see one run there.http://open.odl.local:8063/api/v1/learning_resources/<program_object_id>/items/and look for the course object id above. There should be just one run (published). If you look at that course resource in Django Admin you'll see multiple unpublished runs.