Some minor schema fixes + exporting global const ATTACK_SPEC_VERSION
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutors to robust validator - object_marking_refs was redeclared directly in software.schema as opposed to inheriting from stix-core - Moreover, it was declared as required despite being optional in the STIX 2.1 spec - Additionally, x_mitre_contributors was specified as an optional string array - It should have been mapped to the more robust xMitreContributors schema, which ensures that string elements and the list itself are non-empty
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves some issues relating to
object_marking_refsandx_mitre_contributorsobject_marking_refswas permitting empty lists : changed to enforce.nonempty(). Though the field itself is still optional, if it is defined, it must be non empty.x_mitre_contributorsdefinitions to use the more robustxMitreContributorsSchemarather than defining custom schemas directly within the SDO schema itselfAdditionally, the ADM now exports a global const called
ATTACK_SPEC_VERSIONthat returns the current spec version (3.3.0as of now) to allow ADM library users to determine the spec version within their respective installations.