Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aws config mapper #1794

Merged
merged 13 commits into from
Dec 15, 2021
Merged

Aws config mapper #1794

merged 13 commits into from
Dec 15, 2021

Conversation

Rlin232
Copy link
Contributor

@Rlin232 Rlin232 commented Aug 13, 2021

No description provided.

@mergify
Copy link
Contributor

mergify bot commented Aug 13, 2021

This pull request has a conflict. Could you fix it @Rlin232?

@Rlin232 Rlin232 mentioned this pull request Aug 13, 2021
Closed
6 tasks
@robthew robthew temporarily deployed to mitre-heimda-awsconfigm-dddyvk August 13, 2021 17:44 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@aaronlippold aaronlippold added the enhancement New feature or request label Sep 11, 2021
@jkufro
Copy link

jkufro commented Sep 21, 2021

@Rlin232 see mitre/heimdall_tools#115 for an enhancement to HT version

jkufro
jkufro previously requested changes Oct 15, 2021
View reviewed changes
Copy link

@jkufro jkufro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See all inline comments

@camdenmoors camdenmoors linked an issue Nov 1, 2021 that may be closed by this pull request
Aws config mapper #2136
Closed
@Rlin232 @camdenmoors
Create aws-config-mapper.ts
3ba96d5 
Bypassing merge conflicts

Co-Authored-By: Rlin232 <38306648+Rlin232@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2021

This pull request introduces 1 alert when merging 3ba96d5 into ff09aa4 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Dec 13, 2021

This pull request introduces 1 alert when merging e8600b9 into 21a8be8 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@rbclark rbclark temporarily deployed to heimdall2-awsconfigmapp-79hine December 13, 2021 20:02 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 13, 2021 20:47 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 13, 2021 22:19 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 14, 2021 16:56 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 14, 2021 17:04 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 14, 2021 17:56 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 15, 2021 20:52 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 15, 2021 20:54 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 15, 2021 21:02 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-awsconfigmapp-79hine December 15, 2021 21:05 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@camdenmoors camdenmoors dismissed jkufro’s stale review December 15, 2021 21:20

Not a request for change

@camdenmoors camdenmoors merged commit 99f83c7 into master Dec 15, 2021
@camdenmoors camdenmoors deleted the awsConfigMapper branch December 15, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camdenmoors camdenmoors camdenmoors approved these changes

@jkufro jkufro jkufro left review comments

@ejaronne ejaronne Awaiting requested review from ejaronne

@georgedias georgedias Awaiting requested review from georgedias

@Amndeep7 Amndeep7 Awaiting requested review from Amndeep7

Assignees

@Rlin232 Rlin232

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aws config mapper
6 participants
@Rlin232 @jkufro @camdenmoors @robthew @aaronlippold @rbclark