Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateTenableContentSecurityPolicy #6135

Merged
merged 9 commits into from
Aug 29, 2024
Merged

updateTenableContentSecurityPolicy #6135

merged 9 commits into from
Aug 29, 2024

Conversation

georgedias
Copy link
Contributor

@georgedias georgedias commented Aug 26, 2024 •
edited
Loading

What is improved

Added tenable url to the Heimdall Content Security Policy - this allows cross-domain calls from Heimdall to a defined Tenable URL.

How to test

Please review the .env requirements here. Additionally the browser must allow for CORS, see here for how to configure
Reach out to me for the proper MITRE credentials.

Fixes Issue: #6127

@georgedias
Added tenable hot url to the Heimdall Content Security Policy
08b3dbf 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias added enhancement New feature or request heimdall-frontend Issue is related to the Heimdall-Lite frontend heimdall-backend Issue is related to the Heimdall-Server backend Heimdall Server Issues that relate to Heimdall Server Usability and Value Chain labels Aug 26, 2024
@georgedias
fixed code quality
dfb7cd2 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
fixed if in server or lite mode
1ac3a92 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
added external interfaces variables to the .env-example file
663fbed 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
fixed code quality findings
4ea9156 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Amndeep7
Amndeep7 requested changes Aug 27, 2024
View reviewed changes
apps/backend/src/main.ts Show resolved Hide resolved
apps/frontend/src/store/server.ts Outdated Show resolved Hide resolved
apps/frontend/src/utilities/tenable_util.ts Outdated Show resolved Hide resolved
apps/frontend/src/utilities/tenable_util.ts Outdated Show resolved Hide resolved
apps/frontend/src/utilities/tenable_util.ts Show resolved Hide resolved
@georgedias
added review fixes
c8c999c 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@Amndeep7 Amndeep7 added the ready-to-merge Used by mergify to identify if a PR is ready to merge into master. label Aug 28, 2024
@Amndeep7 Amndeep7 merged commit fcfc565 into master Aug 29, 2024
8 of 9 checks passed
@Amndeep7 Amndeep7 deleted the update_content_security_policy branch August 29, 2024 05:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Amndeep7 approved these changes

@aaronlippold aaronlippold Awaiting requested review from aaronlippold

@DMedina6 DMedina6 Awaiting requested review from DMedina6

Assignees
No one assigned
Labels
enhancement New feature or request Heimdall Server Issues that relate to Heimdall Server Usability and Value Chain heimdall-backend Issue is related to the Heimdall-Server backend heimdall-frontend Issue is related to the Heimdall-Lite frontend ready-to-merge Used by mergify to identify if a PR is ready to merge into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgedias @Amndeep7