Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

389 Integrate Slack With Vulcan #549

Merged
merged 4 commits into from
Mar 27, 2023
Merged

389 Integrate Slack With Vulcan #549

merged 4 commits into from
Mar 27, 2023

Conversation

smarlaku820
Copy link
Contributor

Integrating Slack with Vulcan

Ability to send the following notification items to a private slack channel.

Project

  • Project Creation
  • Project Removal
  • Project Renaming

Component

  • Component Creation
  • Component Removal

SRG

  • SRG Upload
  • SRG Removal

Vulcan Admin

  • Assigning Vulcan Admin
  • Removing Vulcan Admin

Membership Notifications (Project)

  • Add member
  • Update member role
  • Remove member

Membership Notifications (Component)

  • Add member
  • Update member role
  • Remove member

@smarlaku820 smarlaku820 linked an issue Mar 16, 2023 that may be closed by this pull request
389 Integrate Slack With Vulcan #389
Closed
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-549 March 16, 2023 15:38 Inactive
@smarlaku820 smarlaku820 self-assigned this Mar 16, 2023
@smarlaku820
Copy link
Contributor Author

smarlaku820 commented Mar 16, 2023 •
edited

Project Notifications

project_notifs

Hyperlinking the text to go directly to the project page

project_notifs_showing_links

@smarlaku820
Copy link
Contributor Author

smarlaku820 commented Mar 16, 2023 •
edited

Component Notifications & SRG Notifications

vulcan_admin_notifs

srg_notifs

@smarlaku820
Copy link
Contributor Author

Project & Component Notifications

comp_perm_notifs

project_perm_notifs

@smarlaku820 smarlaku820 added documentation enhancement Pull requests that add a new feature V3.0 vmw ruby Pull requests that update Ruby code labels Mar 16, 2023
@smarlaku820 smarlaku820 changed the title 389 an alertnotification system via slack or email to notify users of mentions or actions needed combined with a way to view this in the tool 389 Integrate Slack With Vulcan Mar 16, 2023
vanessuniq
vanessuniq requested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@vanessuniq vanessuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good logic! Code needs to be more DRY. See comments for each file

app/lib/slack_notification_fields.rb Outdated Show resolved Hide resolved
app/controllers/users_controller.rb Show resolved Hide resolved
app/controllers/security_requirements_guides_controller.rb Show resolved Hide resolved
app/controllers/projects_controller.rb Show resolved Hide resolved
app/controllers/memberships_controller.rb Show resolved Hide resolved
app/controllers/components_controller.rb Show resolved Hide resolved
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-549 March 17, 2023 13:02 Inactive
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-549 March 19, 2023 04:46 Inactive
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-549 March 20, 2023 07:44 Inactive
vanessuniq
vanessuniq requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@vanessuniq vanessuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the include SlackNotificationsHelper to the ApplicationController so that all other controllers will automatically inherit it.

@vanessuniq vanessuniq temporarily deployed to vulcan-pr-549 March 20, 2023 16:40 Inactive
@smarlaku820 smarlaku820 force-pushed the 389-an-alertnotification-system-via-slack-or-email-to-notify-users-of-mentions-or-actions-needed-combined-with-a-way-to-view-this-in-the-tool branch from 0eb0679 to 3d8c071 Compare March 24, 2023 16:26
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-549 March 24, 2023 16:26 Inactive
@smarlaku820 smarlaku820 force-pushed the 389-an-alertnotification-system-via-slack-or-email-to-notify-users-of-mentions-or-actions-needed-combined-with-a-way-to-view-this-in-the-tool branch from 3d8c071 to 92b481f Compare March 24, 2023 16:30
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-549 March 24, 2023 16:30 Inactive
@smarlaku820 smarlaku820 force-pushed the 389-an-alertnotification-system-via-slack-or-email-to-notify-users-of-mentions-or-actions-needed-combined-with-a-way-to-view-this-in-the-tool branch from 92b481f to 99edf73 Compare March 24, 2023 16:30
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-549 March 24, 2023 16:31 Inactive
@vanessuniq vanessuniq merged commit 7e988fb into master Mar 27, 2023
@vanessuniq vanessuniq deleted the 389-an-alertnotification-system-via-slack-or-email-to-notify-users-of-mentions-or-actions-needed-combined-with-a-way-to-view-this-in-the-tool branch March 27, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanessuniq vanessuniq vanessuniq approved these changes

@freddyfeelgood freddyfeelgood Awaiting requested review from freddyfeelgood

@rlakey rlakey Awaiting requested review from rlakey

Assignees

@smarlaku820 smarlaku820

Labels
documentation enhancement Pull requests that add a new feature ruby Pull requests that update Ruby code V3.0 vmw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

389 Integrate Slack With Vulcan
2 participants
@smarlaku820 @vanessuniq