Skip to content

Conversation

bradvogel
Copy link
Contributor

Per https://mixmaxhq.atlassian.net/browse/CORE-3434

Changes Made

Makes this module public.

Potential Risks

That there's a company-internal code that we do not want to share. Unlikely, as this is just CI tooling.

Test Plan

  • Without being authenticated to npm (I'm using a bare ec2 instance to test), run npm i @mixmaxhq/commitlint-jenkins. It should install.

Checklist

  • I've increased test coverage
  • Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR.

@bradvogel bradvogel requested a review from ttacon December 2, 2020 14:56
Copy link

@ttacon ttacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few notes:

@bradvogel
Copy link
Contributor Author

@ttacon

@bradvogel
Copy link
Contributor Author

Per my 1-1 chat with @ttacon , we'll make git-hooks public too. Merging this.

@bradvogel bradvogel merged commit 632bc11 into master Dec 3, 2020
@bradvogel bradvogel deleted the make-public branch December 3, 2020 19:00
@mixmax-bot
Copy link
Collaborator

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants