fix: .jsify() error polluting console logs #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matehat
changed the title
There was a problem hiding this comment.
Pull Request Overview
The PR introduces a safeJsify helper to wrap calls to .jsify() and prevent console errors when converting unsupported types, and replaces direct .jsify() invocations across various methods with safeJsify.
- Adds
safeJsifyfunction handling Map, List, DateTime, primitive types, and fallback - Updates all mixpanel-web API calls to use
safeJsifyinstead of direct.jsify() - Provides null-safe fallbacks for configuration and properties
Comments suppressed due to low confidence (3)
lib/mixpanel_flutter_web.dart:8
- There are no unit tests for the new
safeJsifyfunction. Consider adding tests for Maps, Lists, DateTime, primitives, null, and already-JSAnyinputs to verify correct behavior.
JSAny? safeJsify(dynamic value) {
lib/mixpanel_flutter_web.dart:9
- Consider handling
JSAnyinstances first (if (value is JSAny) return value;) so existing JS bindings aren’t wrapped again, avoiding potential double conversion issues.
if (value is Map) {
lib/mixpanel_flutter_web.dart:8
- Add an explicit
if (value == null) return null;check at the start ofsafeJsifyto ensure null inputs are consistently handled and avoid unintended fallbacks.
JSAny? safeJsify(dynamic value) {
| import 'package:flutter_web_plugins/flutter_web_plugins.dart'; | ||
| import 'package:mixpanel_flutter/web/mixpanel_js_bindings.dart'; | ||
|
|
||
| JSAny? safeJsify(dynamic value) { |
There was a problem hiding this comment.
Add a doc comment for safeJsify explaining accepted input types, return values, and its null handling behavior to improve readability and maintainability.
Copilot uses AI. Check for mistakes.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #185