Revert a change I made to TimerEvent handling in ControllerEngine.

Add a note about this change causing segfaults while scratching.
mixxxdj · Dec 4, 2014 · 9744610 · 9744610
1 parent 519ec72
commit 9744610
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/controllers/controllerengine.cpp b/src/controllers/controllerengine.cpp
@@ -1154,7 +1154,11 @@ void ControllerEngine::timerEvent(QTimerEvent *event) {
         return;
     }
 
-    const TimerInfo& timerTarget = it.value();
+    // NOTE(rryan): Do not assign by reference -- make a copy. I have no idea
+    // why but this causes segfaults in ~QScriptValue while scratching if we
+    // don't copy here -- even though internalExecute passes the QScriptValues
+    // by value. *boggle*
+    const TimerInfo timerTarget = it.value();
     if (timerTarget.oneShot) {
         stopTimer(timerId);
     }