Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable qml-formatter until #11386 is fixed #11388

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Disable qml-formatter until #11386 is fixed #11388

merged 1 commit into from
Mar 20, 2023

Conversation

daschuer
Copy link
Member

No description provided.

@JoergAtGithub JoergAtGithub changed the title Disable qml-formatter unit #11386 is fixed Disable qml-formatter until #11386 is fixed Mar 19, 2023
Swiftb0y
Swiftb0y approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anybody will care or have the time enough to actually fix it, so lets disable this until qml work is getting picked up again.

@Swiftb0y Swiftb0y merged commit 146f0bb into mixxxdj:2.4 Mar 20, 2023
@JoergAtGithub
Copy link
Member

Pre-Commit 3.2.1 fixes this: https://github.com/pre-commit/pre-commit/releases/tag/v3.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @JoergAtGithub @Swiftb0y