Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert reverb into a send effect #1260

Merged
merged 1 commit into from
May 15, 2017
Merged

Convert reverb into a send effect #1260

merged 1 commit into from
May 15, 2017

Conversation

ferranpujolcamins
Copy link
Contributor

@Be-ing @timrae
See discussion here: #1254 (comment)

@ferranpujolcamins ferranpujolcamins mentioned this pull request May 13, 2017
Merged
2 tasks
@Be-ing
Copy link
Contributor

Be-ing commented May 13, 2017

Effectively this allows the reverb effect to get louder, which sounds good to me and is fun to play with #1254. If the user doesn't want so much reverb, they can just turn the send parameter/metaknob down (or turn down the deck's fader or chain's mix knob).

@timrae, any thoughts?

@timrae
Copy link
Contributor

timrae commented May 15, 2017

Looks good to me if #1254 is merged

@daschuer
Copy link
Member

LGTM, thank you guys!

@daschuer daschuer merged commit 309457e into mixxxdj:master May 15, 2017
@ferranpujolcamins ferranpujolcamins deleted the reverbSignalPath branch May 14, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferranpujolcamins @Be-ing @timrae @daschuer