CMakeLists: Fix deduplication trap with --preload-file
#12944
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake applies a form of deduplication that, when specifying
would only result in
because it considers
--preload-file
to be a flag that was already set. This leads to very confusing error messages, because the Emscripten compiler would considerb
to be a positional argument (i.e. a source file) rather than a value to--preload-file
.While this currently isn't an issue, because we only set this flag once, the current syntax is misleading and could easily lead to issues if we e.g. split up the resources as proposed in the adjacent TODO comment. For this reason, this PR migrates to the
--preload-file=...
syntax to avoid this.