library redesign code cleanup #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"MixxxLibrary" is easy to confuse with the generic term "Library"
|
Hi Be, I like the change. It will introduce dome conflicts in pending PR, probably easy to resolve. |
Be-ing
changed the title
|
It is a bit concerning to see SQL all over the GUI code. I think that should be factored out of the LibraryFeatures like CrateStorage, but I'll leave that as a to-do task for now. Maybe you want to take care of that @uklotzde? |
|
I tested merging this with #1304, it only creates 2 small conflicts that are very easy to resolve. |
|
Ok, then let's merge this. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading through the code for the library redesign branch, I got really confused between "MixxxLibrary" and the generic term "Library". So rename the "MixxxLibrary" classes to "Tracks", matching the new label in the GUI.