Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Add indication whether controller callback was successfully disconnected #2054

Merged
merged 5 commits into from May 2, 2019

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Mar 12, 2019

While Mapping the NS6II, I encountered a problem where I had to check if the connection is already disconnected.
The added code will set connection.isConnected to true/false accordingly. It will also return whether connection.disconnect() was successful.

TODO:

  • Add tests
  • Add Wiki Documentation

@Swiftb0y Swiftb0y mentioned this pull request Mar 12, 2019
17 tasks
@Be-ing
Copy link
Contributor

Be-ing commented Mar 13, 2019

Nice idea. Would it be better to add a conn.isActive or conn.isConnected property instead of adding another meaning to the id property?

@Swiftb0y
Copy link
Member Author

It would make more sense yes. I just thought using the id would be fine since it has no real purpose in mappings right now. Also isConnected would IMO hint that it was possible to reconnect a disconnected "callback object". Regardless, you are probably right that a dedicated property would be the better choice.

@Swiftb0y Swiftb0y force-pushed the JsCallbackDisconnectFeedback branch from e152268 to e80bbf4 Compare March 19, 2019 19:03
@Swiftb0y Swiftb0y changed the title Add indication whether controller callback was successfully disconnected [DONE] Add indication whether controller callback was successfully disconnected Mar 19, 2019
@uklotzde uklotzde added this to the 2.3.0 milestone Apr 12, 2019
@Be-ing
Copy link
Contributor

Be-ing commented Apr 22, 2019

Looks good to me other than the tab character noted above. Thanks for working on this and documenting it. I think it will be useful for debugging controller scripts. I edited the documentation you added to the wiki to note this will be new in Mixxx 2.3.

Co-Authored-By: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
@Be-ing Be-ing merged commit cb151a7 into mixxxdj:master May 2, 2019
@Holzhaus Holzhaus added this to Done in 2.3 release Mar 14, 2020
@Swiftb0y Swiftb0y mentioned this pull request Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.3 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants