-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pioneer DDJ 200 support #2377
Pioneer DDJ 200 support #2377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contibuting!
The code is rather short and I don't think there are any obvious issues.
However, I didn't find a wiki page for this mapping, which makes it hard to see if there are any problem with the way buttons are mapped.
If you didn't create a wiki page yet, please go ahead and document your mapping here: https://mixxx.org/wiki/doku.php/pioneer_ddj-200?do=edit
For the Pioneer DDJ-400, there's a wiki page here: https://mixxx.org/wiki/doku.php/pioneer_ddj-400
You could use that as a template and delete/change all buttons that do not exist or are mapped differently on the DDJ-200.
@dan-giddins Pinging you in case you didn't see the review comments. ;-) |
|
Another thing: Controller mappings are usually added to the current stable branch ( |
e1443b6
to
fa87468
Compare
@Holzhaus This should be done now? I haven't done a rebase before, so just let me know if anything is wrong |
The rebase worked fine. If it didn't, you'd see all commits from the |
@Holzhaus I've tried making an account on the forums to create the wiki page, but I'm not getting any email with my password in, and therefor I can't log in! Account name = dan-giddins |
@Holzhaus I have managed to get scratching and jogging working, but do you know how I could add this functionality to the jog wheel |
Sorry, we sometimes have problems with forum emails not getting sent. I think the Wiki account and the forum account are not linked, so you can try to create a wiki account here: https://mixxx.org/wiki/doku.php/start?do=register @rryan Can you activate the forum account manually? |
Have a look at: https://github.com/mixxxdj/mixxx/blob/master/res/controllers/Roland_DJ-505-scripts.js#L429-L435 |
@Holzhaus sorry I mean a wiki account. |
@Holzhaus great, just waiting on the wiki account now :) |
I'm sorry for the massive delay. Unfortunately, we were unable to fix the issues with our Wiki mail. We finally moved to GitHub wiki instead, and since you already have a GitHub account you should now be able to create a Wiki page for this controller: https://github.com/mixxxdj/mixxx/wiki |
Ok, you overwrote our config file with the sample configuration. Please undo that. Just install |
I have updated the code accordingly at |
Ignore codefactor. If precommit agrees, all is fine. |
Ok, I think my PR dan-giddins/mixxx-ddj-200-mapping#11 is still valid and has my updates. We also have a new 4 deck mapping. Can we have two mappings (a 2D and 4D version) for the same controller in Mixxx. |
You can also open a new pull request directly from your repo to this one, then I can close this PR.
This needs to be taken care of before we can merge. |
Ok, I have created the PR for the manual. You did a lot of work. Looks very good. Thank you! How can I created a PR from my repo to this one? |
Oh, I just realized you created a new repo for the mapping. You need to fork the mixxx repository (click the little fork button at the top right corner, clone it, run EDIT: in this case it would be nice to keep @dan-giddins in the commit history. So I suggest to fork/clone the Mixxx repo, then run:
Then overwrite the files with your fixed versions, make a new commit, push and open a PR against the 2.2 branch. |
Just a side question: Do we really have to use camel case for all JS variables? |
Yes, please use camelCase for all variables. That also makes it easier to distinguish variables from the actual control. |
And what is the git push command I have to use? |
Use the name of your current branch. If you followed by edited instructions above, use |
Great, that's what I guessed. The PR is here: |
Run
If you found the commit, run this to undo the changes:
This sets the file to the state it had 1 commit before that commit. Now run Then do a rebase to remove the changes from that commit:
Now copy the line with your latest commit (message "foo") right below the line that contains the commit you found via git log and change EDIT: I think commit 9a3742d is the perpetrator. You can simply remove that commit completely:
Then remove the line with that commit id (or replace |
This has been superseeded by #3185, closing this. |
oh, then do it without |
@fkbreitl As you seem much more active with this work, I'm going to leave it up to you to merge this feature into MIXXX. Message me if you want any help, and I am happy to do PRs for you :) |
Thanks @dan-giddins, we are close. Have a look at #3185. |
@dan-giddins The DDJ-200 mapping is in v2.2 now! Also the 4-deck version is on its way! See #3193. |
After updating my cross fader when moved fast to left or right selects automaticly a new song on decks accordingly.... can i still pull a request since its closed? |
Which version are you using? |
2.3.0-beta x64
Sorry for late reaction
…On Tue, 23 Mar 2021, 10:45 Frank Breitling, ***@***.***> wrote:
Which version are you using?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2377 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGAEFII4NXRYTZJLW3HNBWTTFBPLXANCNFSM4JTYQLGQ>
.
|
If you have a fix for this, please open a new pull request. |
i wish, i dont code. this is my fav lead for the ddj and this is what i
experience. dont even know how to pul a request. sorry for that...
…On Fri, 26 Mar 2021 at 20:46, Jan Holthuis ***@***.***> wrote:
If you have a fix for this, please open a new pull request.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2377 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGAEFIMDHPPYKVOPMWI7J5LTFTQCVANCNFSM4JTYQLGQ>
.
|
@Marees213 are you sure you don't have Auto-DJ on? This is a deliberate function of Auto DJ I believe. |
Adding support for the Pioneer DDJ 200