New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp1861433: Fix broken signal/slot connection #2476

Merged

uklotzde merged 1 commit into mixxxdj:master from uklotzde:lp1861433_dlgpreferences

Feb 1, 2020

Contributor

uklotzde commented Jan 31, 2020

https://bugs.launchpad.net/mixxx/+bug/1861433


          Fix broken signal/slot connection

0353ba3

Holzhaus added the major bug label

Member

daschuer commented Jan 31, 2020

SLOT() and SIGNAL() is evil.
I wish we manage to dispose them all soon.
Thank you for the fix.

Member

daschuer commented Jan 31, 2020

LGTM, waiting for ci.

Contributor Author

uklotzde commented Feb 1, 2020

CI failures are unrelated. I'll merge this now myself after the approval (see above).

uklotzde merged commit 983bf3c into mixxxdj:master

uklotzde deleted the lp1861433_dlgpreferences branch

February 1, 2020 22:56

mixxxbot mentioned this pull request

No such slot in src/preferences/dialog/dlgpreferences.cpp:100 #9872

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment