Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp1861433: Fix broken signal/slot connection #2476

Merged
merged 1 commit into from
Feb 1, 2020
Merged

lp1861433: Fix broken signal/slot connection #2476

merged 1 commit into from
Feb 1, 2020

Conversation

uklotzde
Copy link
Contributor

@daschuer
Copy link
Member

SLOT() and SIGNAL() is evil.
I wish we manage to dispose them all soon.
Thank you for the fix.

@daschuer
Copy link
Member

LGTM, waiting for ci.

@uklotzde
Copy link
Contributor Author

uklotzde commented Feb 1, 2020

CI failures are unrelated. I'll merge this now myself after the approval (see above).

@uklotzde uklotzde merged commit 983bf3c into mixxxdj:master Feb 1, 2020
@uklotzde uklotzde deleted the lp1861433_dlgpreferences branch February 1, 2020 22:56
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
major bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @daschuer @Holzhaus