Support hiding menubar and add menubarbutton #3189

poelzi · 2020-10-19T09:53:13Z

Add a new widget MainMenuBarButton that will show the same menu
as the mainmenu bar. Show the button in the skin if the main
menubar is hidden.

DONE: Next step is to add a checkbox in view "[ ] show menubar". The MainMenuBar button is only shown if the main menu is off.

I think this allows the best of 2 worlds, visual impaired or old school friends can stay with the menubar.
Those who want to save the space can have access to the menu with a single button.

uklotzde

Thanks for adopting this task! Just some technical comments, I haven't tested it yet.

Please enable all warnings for local development to avoid commits that are rejected by the CI builds.

uklotzde · 2020-10-19T10:23:05Z

src/widget/wmainmenubar.cpp

@@ -60,6 +60,11 @@ WMainMenuBar::WMainMenuBar(QWidget* pParent, UserSettingsPointer pConfig,
 }

 void WMainMenuBar::initialize() {
+    WMainMenuBar* target = this;
+    createMenu([target](QMenu* x) { target->addMenu(x); });


I would prefer a one-line:

createMenu([this](QMenu* pMenu) { addMenu(pMenu); });

src/widget/wmainmenubar.cpp

src/widget/wmainmenubar.h

src/widget/wmainmenubarbutton.h

src/widget/wmainmenubarbutton.cpp

uklotzde · 2020-10-19T10:35:04Z

src/widget/wmainmenubarbutton.cpp

+void WMainMenuBarButton::initialize(WMainMenuBar* pMainMenu) {
+    m_pMenu = new QMenu(this);
+    setMenu(m_pMenu);
+    pMainMenu->createMenu([=](QMenu* x) { this->m_pMenu->addMenu(x); });


In C++ I would prefer to explicitly capture the context:

pMainMenu->createMenu([this](QMenu* x) { m_pMenu->addMenu(x) });

src/widget/wmainmenubarbutton.h

poelzi · 2020-10-19T11:02:31Z

@uklotzde Thanks for the technical feedback, but I was more interested if this approach is feasible for everyone, not about the code yet. I know it's unpolished, I just wanted to test if I can get it working as I thought.

ronso0 · 2020-10-19T14:50:00Z

At first start, the visibility controls in the regular View menu didn't work.

ronso0 · 2020-10-19T15:01:44Z

I prefer to continue the discussion in Zulip: Getting rid of the menu bar so we have it in one place.
IME it happens too often that with different PRs touching the same issue information and opinions are scattered and we don't actually move forward as fast as we could.

poelzi · 2020-10-20T00:44:08Z

I added Deer and LateNight support so far, LateNight could use some more styling.
So far, there is only one bug left I found: fullscreen messes the menus up.

mixxx/src/mixxx.cpp

Line 1312 in 284db1e

createMenuBar();

Does anyone anything about this ugly workaround ?
Does unsetting and setting the menubar to the mainwindow also fix the problem or does it have to be a newly constructed menubar ?
The reported bug is from mixxx 1.x, I can't imaging ubuntu desktop being broken for so long.

daschuer · 2020-10-20T06:22:37Z

I like the solution here, because calling the menu dies not resize the skin.

ronso0 · 2020-10-20T14:48:12Z

Yes, this here is more complete but also more complex. The shortcut Ctrl+7 is a nice addition, as well.

I like the solution here, because calling the menu dies not resize the skin.

@daschuer Both here and in #3184 the skin is resized when toggling the menu bar, or what do you mean?

In #3184 the menus are accessible even when they're not visible, for example Ctrl+F for the File menu, and arrow keys can select other menus.
This PR does not yet have a way to open menus with the keyboard.

Depending on how long the review and testing takes, we could also use #3184 until thi sis finished.

@mixxxdj/developers
Btw, I think both solutions could make it into 2.3 as a nice UI improvement (again, depending on how quick we can test on all OS): finally a clean full screen view!

ronso0 · 2020-10-20T22:15:54Z

Does anyone anything about this ugly workaround ?
Does unsetting and setting the menubar to the mainwindow also fix the problem or does it have to be a newly constructed menubar ?
The reported bug is from mixxx 1.x, I can't imaging ubuntu desktop being broken for so long.

At least on xUbunut 20.04 this hack is not required.
@daschuer Cna you test on your Ubuntu 18.04 machine?

ronso0 · 2020-10-20T22:16:29Z

@poelzi What do you mena by 'messing up the menus'? Works nicely here.

ronso0 · 2020-10-21T13:36:44Z

(I just hid the pre-commit hook posts, please discuss this in #3195 only)

daschuer · 2020-10-21T13:49:30Z

All becomes messed up when you switch to full screen and back on Ubuntu Bionic

daschuer · 2020-10-21T14:44:15Z

@daschuer Cna you test on your Ubuntu 18.04 machine?

It is not required for Gnome desktops, which have no global menu bar, but it is still required for Unity which features one.

daschuer · 2020-10-21T14:54:56Z

With https://extensions.gnome.org/extension/1250/gnome-global-application-menu/ installed on Ubuntu Gnome Mixxx has no menu at all without the hack and a looooong start delay.

Warning [Main]: Failed to unregister window menu, reason: org.freedesktop.DBus.Error.NoReply ("Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.")
Debug [Main]: Loading resources from  "/home/daniel/workspace/advanced_autodj_2/

poelzi · 2020-10-26T22:10:33Z

I did some testing on unity and it turned out, hide() and show() on the menubar is enough, it does not have to be rebuild.

poelzi · 2020-10-26T22:11:10Z

I will test gnome soon

poelzi · 2020-11-04T23:41:53Z

@daschuer I tested the new workaround on 18.04 and 19.04 and the menubar now works in fullscreen and switching.
I'm now happy with the functionality.

Run in fullscreen, restart mixxxx. Now mixxx starts in fullscreen but the menu shows fullscreen not set. This happens because restore geomentry also restores the fullscreen flag. Emitting a proper signal in the boot phase fixes the desync.

Loading geometry is not a very safe operation, better skip this in safe-mode

WMainMenu is now only the holder of the QActions, Visibility connections and menu logic. It creates new QMenuBar instances on demand requested by the main window. Simplify workaround code.

Shade does not support vinyl, so we need a feature flag as well

restore styling from menubar.

daschuer · 2020-12-14T15:29:07Z

In full screen mode the menu pops up it the wrong place:

daschuer · 2020-12-14T15:37:15Z

The unity menu integration is now always broken the menu. Is always attached on top of the window.

daschuer · 2020-12-14T15:38:09Z

clazy is complaining old style connects.

daschuer · 2020-12-14T15:44:41Z

The integration into global menu, at least on linux does not work reliable and I just can't figure out how to do it that, but I guess since most will not use the menubar anyways, I think it makes sense to disable native menubar and make the hamburger menu the default.

This feels like a regression. This is relevant on small scenes, especially because the burger menu is not available with Shade.

The menu integration issue starts once one is trying to switch between menu bar and burger menu. Is there really a use case for this? I guess not so it should be OK to require Mixxx to restart, after the menu bar is hidden.

github-actions · 2021-03-15T00:18:42Z

This PR is marked as stale because it has been open 90 days with no activity.

ronso0 · 2024-05-23T14:05:38Z

I'm closing this for now, many conflicts have emerged.
If anyone wants to pick it up / rebase / overhaul, the branch is still available.

poelzi marked this pull request as draft October 19, 2020 10:06

poelzi mentioned this pull request Oct 19, 2020

allow to hide the menu bar with [Controls],show_menubar #3184

Closed

4 tasks

uklotzde reviewed Oct 19, 2020

View reviewed changes

poelzi force-pushed the menubutton branch from 7b2fc04 to 284db1e Compare October 20, 2020 00:32

github-actions bot added build skins ui labels Oct 20, 2020

This comment has been minimized.

Sign in to view

daschuer changed the base branch from master to main October 21, 2020 11:17

This comment has been minimized.

Sign in to view

poelzi requested a review from uklotzde November 4, 2020 23:23

poelzi force-pushed the menubutton branch from cc5a201 to 4229805 Compare November 4, 2020 23:38

poelzi marked this pull request as ready for review November 4, 2020 23:40

poelzi changed the title ~~[WIP] Support hiding menubar and add menubarbutton~~ Support hiding menubar and add menubarbutton Nov 5, 2020

poelzi added 11 commits December 13, 2020 21:25

Add tooltip to mainmenubar button

56f6176

Never restore geometry in safe-mode

9375b80

Loading geometry is not a very safe operation, better skip this in safe-mode

Redesign Mainmenu Architecture

2d3cf2a

WMainMenu is now only the holder of the QActions, Visibility connections and menu logic. It creates new QMenuBar instances on demand requested by the main window. Simplify workaround code.

Use info not warning for skin COs

85fbc0a

remove useless code

db0e39f

Use feature COs to detect skin features

ff26a07

Use feature flags in skin for detecting supported functionality

bcc4930

Finish menubarbutton skinning

1e95655

Also guard vinylcontrols with feature flag

0921e95

Shade does not support vinyl, so we need a feature flag as well

Disable menubar by default

446a20d

restore styling from menubar.

poelzi force-pushed the menubutton branch from 28df2a9 to 446a20d Compare December 14, 2020 00:08

poelzi requested a review from daschuer December 14, 2020 00:09

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Mar 15, 2021

poelzi mentioned this pull request Apr 13, 2021

LateNight: style main menubar #3704

Merged

6 tasks

ronso0 mentioned this pull request Nov 16, 2021

Use info not warning for skin COs #4525

Merged

ronso0 mentioned this pull request Jan 25, 2022

Create wmainmenubar controls in coreservices so they are available to controllers on startup #4647

Merged

This was referenced Aug 22, 2022

Hide MenuBar with a KeyStroke #5556

Closed

hide menu in full screen mode #8902

Closed

gtk appmenu #10383

Closed

JoergAtGithub mentioned this pull request Mar 12, 2023

toggle the menubar with single Alt key press #11304

Closed

9 tasks

ronso0 mentioned this pull request Aug 26, 2023

toggle the menubar with single Alt key press (auto hide) #11526

Merged

ronso0 mentioned this pull request May 23, 2024

Top bar icon to toggle the menu? To avoid having to context switch to the keyboard only to press Alt #13266

Open

ronso0 closed this May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support hiding menubar and add menubarbutton #3189

Support hiding menubar and add menubarbutton #3189

poelzi commented Oct 19, 2020 •

edited

Loading

uklotzde left a comment

uklotzde Oct 19, 2020

uklotzde Oct 19, 2020

poelzi commented Oct 19, 2020

ronso0 commented Oct 19, 2020

ronso0 commented Oct 19, 2020

poelzi commented Oct 20, 2020

daschuer commented Oct 20, 2020

ronso0 commented Oct 20, 2020 •

edited

Loading

ronso0 commented Oct 20, 2020

ronso0 commented Oct 20, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ronso0 commented Oct 21, 2020

daschuer commented Oct 21, 2020

daschuer commented Oct 21, 2020

daschuer commented Oct 21, 2020

poelzi commented Oct 26, 2020

poelzi commented Oct 26, 2020

poelzi commented Nov 4, 2020

daschuer commented Dec 14, 2020

daschuer commented Dec 14, 2020

daschuer commented Dec 14, 2020

daschuer commented Dec 14, 2020

github-actions bot commented Mar 15, 2021

ronso0 commented May 23, 2024

Support hiding menubar and add menubarbutton #3189

Support hiding menubar and add menubarbutton #3189

Conversation

poelzi commented Oct 19, 2020 • edited Loading

uklotzde left a comment

Choose a reason for hiding this comment

uklotzde Oct 19, 2020

Choose a reason for hiding this comment

uklotzde Oct 19, 2020

Choose a reason for hiding this comment

poelzi commented Oct 19, 2020

ronso0 commented Oct 19, 2020

ronso0 commented Oct 19, 2020

poelzi commented Oct 20, 2020

daschuer commented Oct 20, 2020

ronso0 commented Oct 20, 2020 • edited Loading

ronso0 commented Oct 20, 2020

ronso0 commented Oct 20, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ronso0 commented Oct 21, 2020

daschuer commented Oct 21, 2020

daschuer commented Oct 21, 2020

daschuer commented Oct 21, 2020

poelzi commented Oct 26, 2020

poelzi commented Oct 26, 2020

poelzi commented Nov 4, 2020

daschuer commented Dec 14, 2020

daschuer commented Dec 14, 2020

daschuer commented Dec 14, 2020

daschuer commented Dec 14, 2020

github-actions bot commented Mar 15, 2021

ronso0 commented May 23, 2024

poelzi commented Oct 19, 2020 •

edited

Loading

ronso0 commented Oct 20, 2020 •

edited

Loading