Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows codesign #3369

Merged
merged 2 commits into from
Nov 28, 2020
Merged

Windows codesign #3369

merged 2 commits into from
Nov 28, 2020

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus added the build label Nov 24, 2020
@Holzhaus Holzhaus added this to the 2.3.0 milestone Nov 24, 2020
Be-ing
Be-ing reviewed Nov 24, 2020
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
Be-ing
Be-ing reviewed Nov 24, 2020
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
Be-ing
Be-ing reviewed Nov 24, 2020
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@Be-ing
Copy link
Contributor

Be-ing commented Nov 25, 2020

Thanks again for working on this.

Be-ing
Be-ing reviewed Nov 25, 2020
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@Holzhaus Holzhaus force-pushed the windows-codesign branch 2 times, most recently from 83bde2b to b121053 Compare November 25, 2020 13:01
@Be-ing
Copy link
Contributor

Be-ing commented Nov 25, 2020

Rebase on 2.3 to include b1dda31

@Holzhaus Holzhaus force-pushed the windows-codesign branch 8 times, most recently from 42d40b5 to 4b95115 Compare November 26, 2020 16:21
@Holzhaus Holzhaus force-pushed the windows-codesign branch 10 times, most recently from 4fe2d9d to 6c978cd Compare November 27, 2020 18:33
@Holzhaus Holzhaus force-pushed the windows-codesign branch 3 times, most recently from fafe213 to aa99b1e Compare November 28, 2020 01:04
Be-ing
Be-ing reviewed Nov 28, 2020
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@Be-ing
Copy link
Contributor

Be-ing commented Nov 28, 2020

It works!

@Holzhaus Holzhaus force-pushed the windows-codesign branch 2 times, most recently from 0176d80 to 3cd029b Compare November 28, 2020 12:15
@Holzhaus Holzhaus marked this pull request as ready for review November 28, 2020 12:15
@Be-ing Be-ing merged commit 41733b9 into 2.3 Nov 28, 2020
@Be-ing Be-ing deleted the windows-codesign branch November 28, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing left review comments

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @Be-ing