Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some MSVC warnings #3377

Merged
merged 8 commits into from
Nov 28, 2020
Merged

Fix some MSVC warnings #3377

merged 8 commits into from
Nov 28, 2020

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus added this to the 2.3.0 milestone Nov 27, 2020
uklotzde
uklotzde suggested changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor semantic inconsistency that needs to be fixed to avoid losing meaning. I already committed a minor optimization.

src/controllers/controllerdebug.h Outdated Show resolved Hide resolved
uklotzde
uklotzde approved these changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for Windows CI build.

@uklotzde uklotzde merged commit 04f39ec into mixxxdj:2.3 Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
build code quality library
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @uklotzde