Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1908475 fix detect latest traktor library #3588

Merged
merged 3 commits into from
Jan 23, 2021
Merged

1908475 fix detect latest traktor library #3588

merged 3 commits into from
Jan 23, 2021

Conversation

denvercoder21
Copy link
Contributor

Fixes "Traktor library feature doesn't use latest library"
(https://bugs.launchpad.net/mixxx/+bug/1908475)

@Be-ing Be-ing merged commit 7de4f9c into mixxxdj:2.3 Jan 23, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Jan 23, 2021

Thanks! Would you be interested in adding support for importing cues from Traktor? This was started a while ago with #1411 but stalled because we didn't know how to handle the timing shifts with different MP3 decoders. @pestrela has since done some excellent research so we can handle that now. We already have a modified version of mp3guessenc in the Mixxx source tree that we are using for the Rekordbox USB drive import.

@Be-ing
Copy link
Contributor

Be-ing commented Jan 23, 2021

Merging this to the main branch is waiting for an unrelated merge conflict to be resolved: #3579 (comment)

@denvercoder21 denvercoder21 deleted the 1908475-fix-detect-latest-traktor-library branch January 23, 2021 22:25
@denvercoder21
Copy link
Contributor Author

Thanks! Would you be interested in adding support for importing cues from Traktor? This was started a while ago with #1411 but stalled because we didn't know how to handle the timing shifts with different MP3 decoders. @pestrela has since done some excellent research so we can handle that now. We already have a modified version of mp3guessenc in the Mixxx source tree that we are using for the Rekordbox USB drive import.

Thanks for the review! I can take a look but can't promis much, not really an area I have had much looked into.

@Be-ing
Copy link
Contributor

Be-ing commented Feb 9, 2021

I factored out SemanticVersion into a utility class in 2c3f040 to use in 785b2ed. Thanks again @denvercoder21 for introducing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants