Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Disable Ubuntu 18.04 CI build #3687

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Mar 9, 2021

Ubuntu 18.04 will not be supported for 2.4.

This is a prerequisite for PR #3038. Due to the old Qt 5.9 in Ubuntu the tests fail because const (ES6/7) does not work (Qt < 5.12 only supports ES3):

warning [0x56218251da90] LINT: "/home/runner/work/mixxx/mixxx/res/controllers/Traktor Kontrol Z2.hid.xml" has no forum link.
warning [0x56218251da90] LINT: "/home/runner/work/mixxx/mixxx/res/controllers/Traktor Kontrol Z2.hid.xml" has no wiki link.
warning [0x56218251da90] QFileSystemWatcher::removePaths: list is empty
warning [0x56218251da90] ControllerScriptHandlerBase: "Uncaught exception at line 12 in file /home/runner/work/mixxx/mixxx/res/controllers/Traktor-Kontrol-Z2-hid-scripts.js.\n\nException:\n  SyntaxError: Syntax error"
critical [0x56218251da90] DEBUG ASSERT: "m_pJSEngine" in function bool ControllerScriptEngineLegacy::callFunctionOnObjects(const QList<QString>&, const QString&, const QJSValueList&, bool) at /home/runner/work/mixxx/mixxx/src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp:29

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time to move on! LGTM

@uklotzde uklotzde merged commit 03be135 into mixxxdj:main Mar 10, 2021
@uklotzde
Copy link
Contributor

After arriving in December 2018 we can finally get rid of some workarounds, see QT_VERSION_CHECK.

Especially using QMetaObject::invokeMethod() becomes easier and safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants