lp1929141: Fix handling of preview button cell events #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linearize the control flow - Delete an invalid debug assertion and explain why
daschuer
reviewed
Sep 5, 2021
| parentTableView()->closePersistentEditor(m_currentEditedCellIndex); | ||
| m_currentEditedCellIndex = QModelIndex(); |
|
Ping. Should be easy to review. |
|
Looks good and works as desired. Thank you. |
daschuer
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.launchpad.net/mixxx/+bug/1929141
No changelog entry, because this is not a user facing bug. Only annoying for developers.