Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrackExportDlg: replace deprecated setButtonText with addButton #4441

Merged
merged 1 commit into from
Oct 16, 2021
Merged

TrackExportDlg: replace deprecated setButtonText with addButton #4441

merged 1 commit into from
Oct 16, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 16, 2021

@ronso0
Copy link
Member

ronso0 commented Oct 16, 2021

LGTM

@ronso0 ronso0 merged commit b512051 into mixxxdj:main Oct 16, 2021
@Be-ing Be-ing deleted the addbutton branch October 16, 2021 20:38
@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 16, 2021

Thank you for the fast merge but please do wait for CI before merging.

@ronso0
Copy link
Member

ronso0 commented Oct 16, 2021

I'll wait for CI next time, but I'm already using it in #3212 without issues.
(which is waiting for final review btw)

@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
library
Projects
Qt6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @ronso0