-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't wipe inapplicable sound config immediately #4544
Conversation
Thank you for picking this up. This part can make use of an overhaul anyway. |
Seeing that the Jack ApI becoming more and more popular, we may consider the external routing use case in all our future steps. We have for instance the issue that you start Mixxx, connect to an JACK output gapping through the routing stage. If later the user uses QJackControl to re-route the sound, Mixxx is not aware from it and displays wrong Info. I think that can be done by separate the "stream enable" task from the "connect to physical output" task. |
84e42de
to
0b95424
Compare
Ready! |
oh, actually this should go to 2.3 |
0b95424
to
b570bf5
Compare
Rebased, ready again. |
No CI except Pull Request Labeler?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you.
When
SoundManager
is initialized and previously configured output devices aren't available the config is wiped and the default config is written to disk before the user had a chance to intervene.With this commit the new config (empty default or reconfigured) is written to disk only if the user clicked either Continue (with no outputs) or Reconfigure (and actually set an output device).
WIP though I'd appreciate feedback is this approach is acceptable until Mixxx supports multiple sound config profiles.
I didn't yet manage to comprehend how all sound devices config steps and sound error dialogs play together. I have the feeling that the inapplicable config should be discovered earlier, not just when configured outputs are missing.