Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove from disk: UI fixes #4639

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Remove from disk: UI fixes #4639

merged 2 commits into from
Jan 22, 2022

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 21, 2022 •
edited
Loading

small fixes for #3212

  • fix the false-positive "Not deleted" message
  • don't focus file lists in confirmation and success dialog to enhance keyboard (and controller) navigation

@github-actions github-actions bot added the ui label Jan 21, 2022
@ronso0 ronso0 added the library label Jan 21, 2022
uklotzde
uklotzde approved these changes Jan 21, 2022
View reviewed changes
src/widget/wtrackmenu.cpp Show resolved Hide resolved
uklotzde
uklotzde approved these changes Jan 22, 2022
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit b10a4db into mixxxdj:main Jan 22, 2022
@ronso0 ronso0 deleted the remove-from-disk-ui-fixes branch January 22, 2022 12:23
@ronso0 ronso0 mentioned this pull request Feb 3, 2022
Merged
@ronso0 ronso0 added this to the 2.4.0 milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
library ui
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @uklotzde