Make Mixxx build with Qt6 #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the Qt docs: > Note: This function is deprecated. For new code, use setSecsSinceEpoch(). > > Source: https://doc.qt.io/qt-5/qdatetime-obsolete.html#setTime_t
This is more efficient and also fixes a potential issue with Qt 6:
‘QSqlQuery::QSqlQuery(const QSqlQuery&)’ is deprecated: QSqlQuery is not meant to be copied. Use move construction instead. [-Werror=deprecated-declarations]
438 | parsePlaylistEntries(xml, current_path,
| ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
In contrast to the `const char*` comparison, the comparison with QLatin1String is forward compatible with Qt 6.
These version checks actually result in compiler errors when trying to build this with Qt 6.
Qt6 replaces QStringRef with QStringView and updates the regular QString::left()/QString::mid() methods to return those.
That class is not available with Qt6.
This is not ideal, the whole VisualPlayPosition/VSyncThead stuff needs to be removed eventually.
This also fixes a test failure with Qt6. It's unknown why this happens, but the new code works with both Qt5 and Qt6 and is more readable and ideomatic anyway.
This makes is much easier to fix linker errors.
uklotzde
reviewed
Jan 22, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.