AsyncImageProvider: Retrieve Cover Art from database instead of file system #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slot/Q_INVOKABLE + QMetaObject::invokeMethod() ensures thread-affinity. But it also requires to handle the result asynchronously in a callback/slot -> hopping between event loop threads. |
Co-Authored-By: Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de>
Holzhaus
force-pushed
the
qml-asyncimageprovider-gettrackfromcollection
branch
from
9cb2aa3
to
dfca6f9
Compare
Holzhaus
changed the title
uklotzde
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggers the following debug assertion:Unfortunately, we need something like this to be able to draw waveforms, waveform overviews and coverart in another thread.Any ideas how to resolve this?