Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaFoundation: remove redundant m4v type #4683

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

daschuer
Copy link
Member

It is already registered as mp4.
This should fix a debug assertion in https://bugs.launchpad.net/mixxx/+bug/1961623

@Holzhaus
Copy link
Member

Not really familiar with the code, but shouldn't we remove the mp4 line instead? AFAIK it's a container format and can contain video or audio. m4a and m4v are distinct.

@daschuer
Copy link
Member Author

This is related to the magic number detection, see:
https://www.garykessler.net/library/file_sigs.html

These files are detected as "video/mp4" and we use the file type "mp4" in Mixxx, which matches the QMimeType::preferredSuffix().

"audio/m4a" are detected explicit.

We also use "mp4" here as well:

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using type "mp4" for the suffix ".m4v" seems to be consistent with the remaining code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants