WBeatSpinBox/WEffectSelector: pass focus to tracks via focus CO #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
Jul 6, 2022
src/widget/wbeatspinbox.cpp
Outdated
| QKeyEvent backwardFocusKeyEvent = | ||
| QKeyEvent{QEvent::KeyPress, Qt::Key_Backtab, Qt::NoModifier}; | ||
| QApplication::sendEvent(this, &backwardFocusKeyEvent); | ||
| auto* libraryFocusCO = ControlObject::getControl("[Library]", "focused_widget"); |
There was a problem hiding this comment.
This can be done at once via:
ControlObject::set(ConfigKey(Library]", "focused_widget"), static_cast(FocusWidget::TracksTable));
The cast should be double to avoid the implicit double conversion.
The same below.
There was a problem hiding this comment.
oh, thank you!
I wonder why, in other places, we first get the CO, then check for !nullptr before setting it, while this is already implemented in ControlObject::set(). Example
There was a problem hiding this comment.
This is because ControlObject::set() has been introduced after the code was already there.
There was a problem hiding this comment.
ah okay. So whenever I stumble over it I can safely replace it. Good to know.
daschuer
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the KeyEvent hack from #4617