Effect chain: (re)load & select preset after saving with a new name #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Aug 16, 2022
ronso0
force-pushed
the
effect-chain-select-after-save-as-new
branch
from
9615568
to
c4563bc
Compare
This will select the new preset in WEffectChainMenuButton and WEffectChainPresetSelector
ronso0
force-pushed
the
effect-chain-select-after-save-as-new
branch
from
c4563bc
to
49e301e
Compare
Swiftb0y
approved these changes
Aug 21, 2022
daschuer
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1986439
Save preset with new name, and the new preset will be loaded and selected in WEffectChainMenuButton and WEffectChainPresetSelector.
Note: I didn't check wether the internediate preset unload causes sound issues. Please test.