Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ENH: Adds license message on first import" #86

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

miykael
Copy link
Owner

@miykael miykael commented Jan 8, 2019

Tests on TravisCI were failing because of the license check introduced with PR #71. This was the case for general tests (https://travis-ci.org/miykael/atlasreader/jobs/476838506) as well as for tests in the notebook (https://travis-ci.org/miykael/atlasreader/jobs/476838507).

@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6a7ec04). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #86   +/-   ##
=========================================
  Coverage          ?   87.87%           
=========================================
  Files             ?        6           
  Lines             ?      396           
  Branches          ?        0           
=========================================
  Hits              ?      348           
  Misses            ?       48           
  Partials          ?        0
Impacted Files Coverage Δ
atlasreader/__init__.py 100% <ø> (ø)
atlasreader/tests/test_cli.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7ec04...2e9c0c2. Read the comment docs.

@miykael miykael merged commit 3f95b64 into master Jan 8, 2019
@miykael miykael deleted the revert-71-importmsg branch January 8, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants