has_content? function is not reliable with loops

[mjpete3]

The has_content? function does not return a reliably when dealing with loops. Recursive structure causes the function to run through the entire structure and not short circuit itself.

[mjpete3]

Sean,

I actually dug into the code. figured out what I was doing wrong.
Also I've been maintaining a separate gem: pd_x12. I've had several
people ask for additional transactions.

If you are ok, I would like to take a look at what you did with the
loops and merge it into the gem I'm maintaining.

Marty

On Wed, 2013-03-20 at 05:30 -0700, Sean Walberg wrote:

Hi,

I'm sorry, I didn't see this issue before. Do you have a small sample
to duplicate the problem? I recently merged some changes that deal
with loops, too.

—
Reply to this email directly or view it on GitHub.

[swalberg]

Hi Marty,

For sure!

Alternatively, did you want to submit them as pull requests? I've been
talking with the original author of the gem and have moved my repo to an
organization (x12ruby/x12) and will soon be getting access to update the
x12 gem over on RubyGems.org. He's basically abandoned the project.

Thanks,

Sean

On Fri, Mar 22, 2013 at 8:53 AM, MJPete3 notifications@github.com wrote:

Sean,

I actually dug into the code. figured out what I was doing wrong.
Also I've been maintaining a separate gem: pd_x12. I've had several
people ask for additional transactions.

If you are ok, I would like to take a look at what you did with the
loops and merge it into the gem I'm maintaining.

Marty

On Wed, 2013-03-20 at 05:30 -0700, Sean Walberg wrote:

Hi,

I'm sorry, I didn't see this issue before. Do you have a small sample
to duplicate the problem? I recently merged some changes that deal
with loops, too.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-15297599
.

Sean Walberg sean@ertw.com http://ertw.com/