Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create toolbox widget #27

Open
mkatch opened this issue Jun 11, 2014 · 2 comments
Open

Create toolbox widget #27

mkatch opened this issue Jun 11, 2014 · 2 comments
Assignees

Comments

@mkatch
Copy link
Owner

mkatch commented Jun 11, 2014

We should have a toolbox on the left side of the application window. A toolbox is a 2-column vertical bar with tool icons that allow the user to switch between tools. Also the toolbox should also hold the colors currently painted with and the size of the pen.sketch

This enhancement needs adding some appearance information to Tool. This could be done by expanding the Tool class with additional properties and methods. But I would personally prefer it stayed separated from it. This can be achieved by creating a wrapper like ToolBoxItem or something, which internally held a Tool and appearance information.

Appearance information includes, obviously, an icon that appears in toolbox. But also a tooltip, that appears when the user holdt the cursor over the icon. We could possibly also have some tool grouping which also counts as appearance information (or layout information). Like for example there would be a hollow rect tool and filled rect tool and the user would choose either of them by clicking an aggregating tool icon which then expand context-menu style and shows the two tools. (I don't think there would be separate tool for filled and hollow rect but you get the idea). It will suffice to just implement the icons atm.

toolbox

@mkatch mkatch added this to the Working draft milestone Jun 11, 2014
@panhania panhania self-assigned this Jun 12, 2014
panhania pushed a commit that referenced this issue Jun 13, 2014
Toolbox now should be able to serve its main purpose as requested in #27.
@mkatch
Copy link
Owner Author

mkatch commented Jun 15, 2014

I have some remarks to the created toolbox widget. Some issues are pointed out as comments to 08ca043. Also the buttons in my OS look terrible and the toolbox is much too wide. Don't know if you experience the same issues. Check out the video to know what I mean.

@mkatch mkatch reopened this Jun 15, 2014
@panhania
Copy link
Collaborator

Also the buttons in my OS look terrible and the toolbox is much too wide.

Well, this is definitely something with your setup. Here is how it looks like on Linux. I completely agree that it definitely has to be fixed but since I do not have any access to OS X system it would be very hard thing to do.

Definetly, absolutely, positively no antialiasing.

Why is that so? It is just a preview to feel the scale, it doesn't even mirror how it would look like onscreen.

Those 6 signals above should be removed.

Fine, I will change that. But if that is the case I need to know more details on how you envision this color editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants