Fixed TC 10 for clang | #32 | #22 | #17 #33
Conversation
|
Hey @mkirchner, is there a provision like Travis where we can run the CI for all PRs, it's easy to see if we are breaking anything. |
We're already running a build matrix, see e.g. here for the merge of your PR: https://github.com/mkirchner/gc/commit/83a2b2fae552facd5b93014f612a8321663846df/checks?check_suite_id=380433639 |
| void *bos = __builtin_frame_address(0); | ||
| gc_start(&gc_, bos); | ||
| void *bos = NULL; | ||
| gc_start(&gc_, &bos); |
There was a problem hiding this comment.
This should not make a difference to the test. Does it?
There was a problem hiding this comment.
The frame address is normally the address of the first word pushed on to the stack by the function. However, the exact definition depends upon the processor and the calling convention
oddly enough, gcc in most 64 bit Intels, it does not seem to be the case, so bos goes bellow whatever that function is returning, thus maintaining, bos, var, tos order.
Yeah, it just worked so I pushed it, I'll investigate more and update here, let's not merge this
test/Makefile
Outdated
| @@ -1,3 +1,4 @@ | |||
| # CC=gcc | |||
There was a problem hiding this comment.
Please remove. To build w/ GCC just use make CC=gcc (the line below just makes clang the default).
There was a problem hiding this comment.
As mentioned bellow, this should not be here, I'll remove it
|
I did a |
|
Okay, I am not able to reproduce it 🤔. I'm closing this PR. One observation that I had, I cannot repor is that __builtin_frame_address was not returning an address before bos variable, thus the stack variable was not getting tagged. |
No description provided.