Don't limit channel window to 500MB #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the channel window and increments were limited to 500MB. That is incorrect and causes stuck connections if peers advertise a large window, then don't send an increment within the first 500MB. That's seen with SSH.NET sshnet/SSH.NET#1671
rockdrilla
added a commit
to rockdrilla/fork.openwrt
that referenced
this pull request
Aug 16, 2025
cherry-pick commit from mkj/dropbear#377 with extra integer overflow checks. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla
added a commit
to rockdrilla/fork.openwrt
that referenced
this pull request
Aug 17, 2025
cherry-pick commit from mkj/dropbear#377 with extra integer overflow checks. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla
added a commit
to rockdrilla/fork.openwrt
that referenced
this pull request
Aug 19, 2025
cherry-pick commit from mkj/dropbear#377 with extra integer overflow checks. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla
added a commit
to rockdrilla/fork.openwrt
that referenced
this pull request
Aug 20, 2025
cherry-pick commit from mkj/dropbear#377 Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
hauke
pushed a commit
to rockdrilla/fork.openwrt
that referenced
this pull request
Aug 23, 2025
cherry-pick commit from mkj/dropbear#377 Signed-off-by: Konstantin Demin <rockdrilla@gmail.com> Link: openwrt#19715 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
igor-dyatlov
pushed a commit
to igor-dyatlov/openwrt
that referenced
this pull request
Aug 26, 2025
cherry-pick commit from mkj/dropbear#377 Signed-off-by: Konstantin Demin <rockdrilla@gmail.com> Link: openwrt#19715 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Aug 27, 2025
cherry-pick commit from mkj/dropbear#377 Signed-off-by: Konstantin Demin <rockdrilla@gmail.com> Link: openwrt#19715 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the channel window and increments were limited to 500MB. That is incorrect and causes stuck connections if peers advertise a large window, then don't send an increment within the first 500MB.
That's seen with SSH.NET sshnet/SSH.NET#1671
Fixes #376