-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
and -> && for msvc #46
Conversation
WalkthroughThis update primarily focuses on enhancing the codebase's readability and consistency by modifying the use of logical operators. Specifically, it replaces instances of the word-based logical operator Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- inc/mkn/kul/os/win/env.hpp (1 hunks)
Additional comments: 1
inc/mkn/kul/os/win/env.hpp (1)
- 87-87: The change from
and
to&&
in theSET
function aligns with the PR's objective of enhancing compatibility and consistency, particularly with the MSVC compiler. This change is correctly implemented and should not affect the functionality of theSET
function, as bothand
and&&
serve the same logical operation purpose. However, it's important to ensure that this change is consistently applied throughout the entire codebase where applicable for uniformity and to avoid confusion.
Summary by CodeRabbit