Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of rubocop-rspec (1.44.1) produced dependency conflicts #82

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 21, 2020

👉 This PR is queued up to get rebased by Depfu

We've tried to upgrade a dependency and got errors running Bundler. It looks like there is a version conflict between two or more dependencies. Depfu doesn't try to solve these, as this would mean to update more than one dependency at a time.

Please take a look at the exact failure to figure out if this is something you need to work on.

The bundler error message was:

Bundler could not find compatible versions for gem "rubocop":
  In Gemfile:
    rubocop (= 0.81.0)

    rubocop-rspec (= 1.44.1) was resolved to 1.44.1, which depends on
      rubocop (~> 0.87)

What changed?

✳️ rubocop-rspec (1.37.1 → 1.44.1) · Repo · Changelog

Release Notes

1.44.1 (from changelog)

1.44.0

  • Move our documentation from rubocop-rspec.readthedocs.io to docs.rubocop.org/rubocop-rspec. (@bquorning)
  • Add RSpec/RepeatedIncludeExample cop. (@biinari)
  • Add RSpec/StubbedMock cop. (@bquorning, @pirj)
  • Add IgnoredMetadata configuration option to RSpec/DescribeClass. (@Rafix02)
  • Fix false positives in RSpec/EmptyExampleGroup. (@pirj)
  • Fix a false positive for RSpec/EmptyExampleGroup when example is defined in an if branch. (@koic)

1.43.2

  • Fix RSpec/FilePath when checking a file with a shared example. (@pirj)
  • Fix subject nesting detection in RSpec/LeadingSubject. (@pirj)

1.43.1

Fix RSpec/FilePath when checking a file defining e.g. an empty class. (@bquorning)

1.43.0

  • Add a new base cop class ::RuboCop::Cop::RSpec::Base. The old base class ::RuboCop::Cop::RSpec::Cop is deprecated, and will be removed in the next major release. (@bquorning)
  • Add support for subject detection after includes and example groups in RSpec/LeadingSubject. (@pirj)
  • Ignore trailing punctuation in context description prefix. (@elliterate)
  • Relax RSpec/VariableDefinition cop so interpolated and multiline strings are accepted even when configured to enforce the symbol style. (@bquorning)
  • Fix RSpec/EmptyExampleGroup to flag example groups with examples in invalid scopes. (@mlarraz)
  • Fix RSpec/EmptyExampleGroup to ignore examples groups with examples defined inside iterators. (@pirj)
  • Improve RSpec/NestedGroups, RSpec/FilePath, RSpec/DescribeMethod, RSpec/MultipleDescribes, RSpec/DescribeClass's top-level example group detection. (@pirj)
  • Add detection of let! with a block-pass or a string literal to RSpec/LetSetup. (@pirj)
  • Add IgnoredPatterns configuration option to RSpec/VariableName. (@jtannas)
  • Add RSpec/MultipleMemoizedHelpers cop. (@mockdeep)

1.42.0

  • Update RuboCop dependency to 0.87.0 because of changes to internal APIs. (@bquorning, @Darhazer)

1.41.0

  • Extend the list of Rails spec types for RSpec/DescribeClass. (@pirj)
  • Fix FactoryBot/AttributeDefinedStatically to allow #traits_for_enum without a block. (@harrylewis)
  • Improve the performance of FactoryBot/AttributeDefinedStatically, RSpec/InstanceVariable, RSpec/LetSetup, RSpec/NestedGroups and RSpec/ReturnFromStub. (@andrykonchin)

1.40.0

  • Add new RSpec/VariableName cop. (@tejasbubane)
  • Add new RSpec/VariableDefinition cop. (@tejasbubane)
  • Expand Capybara/VisibilityMatcher to support more than just have_selector. (@twalpole)
  • Add new SpecSuffixOnly option to RSpec/FilePath cop. (@zdennis)
  • Allow RSpec/RepeatedExampleGroupBody to differ only by described_class. (@robotdana)
  • Fix RSpec/FilePath detection across sibling directories. (@rolfschmidt)
  • Improve the performance of RSpec/SubjectStub by an order of magnitude. (@andrykonchin)

1.39.0

  • Fix RSpec/FilePath detection when absolute path includes test subject. (@eitoball)
  • Add new Capybara/VisibilityMatcher cop. (@aried3r)
  • Ignore String constants by RSpec/Describe. (@AlexWayfer)
  • Drop support for Ruby 2.3. (@bquorning)
  • Fix multiple cops to detect let with proc argument. (@tejasbubane)
  • Add autocorrect support for RSpec/ScatteredLet. (@Darhazer)
  • Add new RSpec/EmptyHook cop. (@tejasbubane)

1.38.1

  • Fix RSpec/RepeatedDescription to detect descriptions with interpolation and methods. (@lazycoder9)

1.38.0

  • Fix RSpec/InstanceVariable detection inside custom matchers. (@pirj)
  • Fix RSpec/ScatteredSetup to distinguish hooks with different metadata. (@pirj)
  • Add autocorrect support for RSpec/ExpectActual cop. (@dduugg, @pirj)
  • Add RSpec/RepeatedExampleGroupBody cop. (@lazycoder9)
  • Add RSpec/RepeatedExampleGroupDescription cop. (@lazycoder9)
  • Add block name and other lines to RSpec/ScatteredSetup message. (@elebow)
  • Fix RSpec/RepeatedDescription to take into account example metadata. (@lazycoder9)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Feb 7, 2022

Closing because this update is no longer necessary.

@depfu depfu bot closed this Feb 7, 2022
@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.44.1 branch February 7, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants