Add Olmo2 #384
Merged
Add Olmo2 #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please run |
|
See the other PR about swift-format 602. This also has conflicts, but might as well wait on this to merge the other PR as it will just conflict again. |
|
ok, #387 pulled in the swift-format change, I think this just needs a rebase and merge fix on LLMModelFactory. That latter item is always a problem -- I wonder if we can do that a different way (with extensions in the model files perhaps?) |
|
@davidkoski Updated to swift format 602 and yes I did run into the issue with LLMModelFactory and for some reason Olmo2.swift was recognized as a new file. Not sure how that happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of Olmo2 https://github.com/ml-explore/mlx-lm/blob/main/mlx_lm/models/olmo2.py