Skip to content

feat: changed DI to @Injectable #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 3, 2022
Merged

feat: changed DI to @Injectable #50

merged 8 commits into from
May 3, 2022

Conversation

johsoe
Copy link
Contributor

@johsoe johsoe commented May 2, 2022

Pull Request (PR) Checklist

  • PR title includes Jira ticket reference -- if no ticket available create one if this PR is a fix or feat
  • Branch name includes Jira ticket reference (parent ticket and sub-task if available), e.g. 'feat/APP-XXX_Some_Feature' or feat/APP-XXX_APP-XXX_Some_Sub_Task or 'fix/APP-XXX_Some_Fix' or 'refactor/Some_Refactoring'
  • All PR checks pass and changes under /domain are covered with unit tests
  • Jira ticket provides testing infos for QA -- add a comment if needed e.q. for pre-requisites, order of API calls, ...
  • When merging this PR the commit message follows conventional-commits, e.g. 'feat(some optional epic): add some feature (APP-XXX) (#XXX)'

Related to other PRs

Notes for PR reviewers

Base automatically changed from refactor/cubit to master May 3, 2022 06:21
pedromassango
pedromassango suggested changes May 3, 2022
View reviewed changes
@pedromassango
Copy link
Contributor

Conflicts 💣

johsoe added 4 commits May 3, 2022 13:29
@johsoe
docs: added TODO
ce509f2
@johsoe
refactor: tweaked DI
30e15e8
@johsoe
Merge branch 'master' of github.com:monstar-lab-oss/flutter-template …
e317078 
…into feat/injectable

� Conflicts:
�	lib/injection/data_module.dart
�	lib/presentation/feature/profile/profile_cubit.dart
�	lib/presentation/feature/profile/profile_module.dart
@johsoe
chore: merging leftovers
6fc06cf
@johsoe johsoe merged commit 48ab2fc into master May 3, 2022
@johsoe johsoe deleted the feat/injectable branch May 3, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pedromassango pedromassango pedromassango approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johsoe @pedromassango