Skip to content

Conversation

johsoe
Copy link
Contributor

@johsoe johsoe commented May 2, 2022

Pull Request (PR) Checklist

  • PR title includes Jira ticket reference -- if no ticket available create one if this PR is a fix or feat
  • Branch name includes Jira ticket reference (parent ticket and sub-task if available), e.g. 'feat/APP-XXX_Some_Feature' or feat/APP-XXX_APP-XXX_Some_Sub_Task or 'fix/APP-XXX_Some_Fix' or 'refactor/Some_Refactoring'
  • All PR checks pass and changes under /domain are covered with unit tests
  • Jira ticket provides testing infos for QA -- add a comment if needed e.q. for pre-requisites, order of API calls, ...
  • When merging this PR the commit message follows conventional-commits, e.g. 'feat(some optional epic): add some feature (APP-XXX) (#XXX)'

Related to other PRs

Notes for PR reviewers

Base automatically changed from feat/injectable to master May 3, 2022 12:04
johsoe added 2 commits May 3, 2022 14:06
…into feat/updateplatforms

� Conflicts:
�	lib/injection/data_module.dart
�	lib/injection/dependencies.dart
�	lib/presentation/feature/profile/profile_cubit.dart
�	lib/presentation/feature/profile/profile_module.dart
@AbbasMathiew AbbasMathiew merged commit df546f2 into master May 4, 2022
@AbbasMathiew AbbasMathiew deleted the feat/updateplatforms branch May 4, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants