feat: Introduce FocusScopeDismissible #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johsoe
approved these changes
May 30, 2022
|
I like that we encourage this behaviour 👍 |
|
@atiqmlbd thoughts? |
atiqaraj
reviewed
May 31, 2022
lib/presentation/widgets/misc/background_focus_scope_dismisser.dart
Outdated
Show resolved
Hide resolved
atiqaraj
reviewed
May 31, 2022
lib/presentation/widgets/misc/background_focus_scope_dismisser.dart
Outdated
Show resolved
Hide resolved
atiqaraj
reviewed
May 31, 2022
lib/presentation/widgets/misc/background_focus_scope_dismisser.dart
Outdated
Show resolved
Hide resolved
atiqaraj
reviewed
May 31, 2022
lib/presentation/widgets/misc/background_focus_scope_dismisser.dart
Outdated
Show resolved
Hide resolved
|
you could follow conventional commit for commit messages and PR title and we could rename misc to components or utilities |
AbbasMathiew
changed the title
atiqaraj
approved these changes
Jul 1, 2022
atiqaraj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the docs, this widget will save you from writing the same code everywhere 🙂